Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jump Code actions #1376

Merged
merged 11 commits into from
Oct 3, 2024
Merged

Update Jump Code actions #1376

merged 11 commits into from
Oct 3, 2024

Conversation

PizieDust
Copy link
Contributor

This PR aims to fix some of the issues related to the Jump code actions.

  • Ability to add specific key-bindings for each jump. Original comment
  • Toggling on and off the display of the jump targets on context menus, (ON by default) Original comment, point 1
  • Navigating to a specific jump on the context menu using the keyboard (pressing the first letter of the jump target) Original comment

cc @voodoos @xvw @rgrinberg @awilliambauer

@PizieDust
Copy link
Contributor Author

@xvw Please add the no-changelog label.

@coveralls
Copy link

coveralls commented Sep 27, 2024

Pull Request Test Coverage Report for Build 4577

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 11 of 45 (24.44%) changed or added relevant lines in 3 files are covered.
  • 159 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.06%) to 21.902%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/code_actions.ml 3 4 75.0%
ocaml-lsp-server/src/config_data.ml 3 36 8.33%
Files with Coverage Reduction New Missed Lines %
ocaml-lsp-server/src/config_data.ml 1 35.62%
ocaml-lsp-server/src/inlay_hints.ml 2 86.96%
ocaml-lsp-server/src/inference.ml 4 70.45%
ocaml-lsp-server/src/signature_help.ml 21 0.0%
ocaml-lsp-server/src/ocaml_lsp_server.ml 131 36.54%
Totals Coverage Status
Change from base Build 4536: 0.06%
Covered Lines: 5558
Relevant Lines: 25377

💛 - Coveralls

@voodoos
Copy link
Collaborator

voodoos commented Sep 30, 2024

@xvw Please add the no-changelog label.

Since we do add usef-facing changes (a new configuration option) we should add it to the changelog :-)

Copy link
Collaborator

@voodoos voodoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, Pizie, overall this looks good to me, I just think we should map the targets to get names that actually start with a distinct letters (namely, rename match-next-case and match-prev-case.

ocaml-lsp-server/docs/ocamllsp/config.md Outdated Show resolved Hide resolved
ocaml-lsp-server/test/e2e-new/code_actions.ml Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@PizieDust PizieDust requested a review from voodoos October 1, 2024 14:08
@voodoos
Copy link
Collaborator

voodoos commented Oct 3, 2024

Thanks everyone!

@voodoos voodoos merged commit 667ef4b into ocaml:master Oct 3, 2024
5 of 7 checks passed
@PizieDust PizieDust deleted the update_jump branch October 3, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants