[T9][F11-C2] #177

njyjn · 2016-10-21T11:52:11Z

Ready for review.

AboutUs finalized. Merged by Justin.

v0.0.1 finalized. Merged by Justin.

Ready to merge. Please note that we use ToDoList in place of TaskManagert—I will manually cherrypick.

… update.

Good work.

Conflicts: src/main/java/seedu/cmdo/commons/core/Config.java

Candiie

Hi guys! Wow, I have a total of 30 review comments lols! I didn't even realized XD Anways do go through all of them and make the necessary changes and close Prs when u're done ~

P.S. Don't waste my efforts & Do go through them cos there are quite a few critical mistakes here and there ~
Jiayous!!!

Candiie · 2016-10-26T09:57:52Z

docs/DeveloperGuide.md

@@ -113,7 +113,7 @@ The `UI` component,

 **API** : [`Logic.java`](../src/main/java/seedu/address/logic/Logic.java)


Hi Guys, its ok to use the existing diagrams, however do take note to update the diagram according to YOUR project's structure! e.g i still see post(AddressBook...) or address book related images everywhere, same for ur UI component, in your case are u sure you are using "PersonCard" ?

Candiie · 2016-10-26T09:59:46Z

docs/DeveloperGuide.md

@@ -113,7 +113,7 @@ The `UI` component,

 **API** : [`Logic.java`](../src/main/java/seedu/address/logic/Logic.java)

-1. `Logic` uses the `Parser` class to parse the user command.


Under UI API Java

The UI consists of a MainWindow that is made up of parts e.g.CommandBox, ResultDisplay, PersonListPanel
~ person ~
do take note to go through all, because if this is seen in the final vetting ~ yupp we all know what will happen ><"

Candiie · 2016-10-26T10:01:05Z

docs/DeveloperGuide.md

@@ -113,7 +113,7 @@ The `UI` component,

 **API** : [`Logic.java`](../src/main/java/seedu/address/logic/Logic.java)

-1. `Logic` uses the `Parser` class to parse the user command.
+1. `Logic` uses the `MainParser` class to parse the user command. `MainParser` relies on `Parser` of [Natty by Joe Stelmach](https://github.com/joestelmach/natty) for natural language processing.


For the logic diagram, i'm sure you guys have more then add, list commands, do add in a few more too since there's still spaces and do update the image to how your logic work in ur program :)

Candiie · 2016-10-26T10:03:08Z

docs/DeveloperGuide.md

@@ -113,7 +113,7 @@ The `UI` component,

 **API** : [`Logic.java`](../src/main/java/seedu/address/logic/Logic.java)

-1. `Logic` uses the `Parser` class to parse the user command.
+1. `Logic` uses the `MainParser` class to parse the user command. `MainParser` relies on `Parser` of [Natty by Joe Stelmach](https://github.com/joestelmach/natty) for natural language processing.
 2. This results in a `Command` object which is executed by the `LogicManager`.
 3. The command execution can affect the `Model` (e.g. adding a person) and/or raise events.


"person here"
btw i'm not being naggy ok ~ since i'm already going through i'll try to mark those that I can find so that u guys have an easier life to do the neccessary changes ~ however, do note to not only change the names but also the explanation if neccessary ~ when we go through your logic codes, we expect it to run in a similar manner as explained

or shown in ur diaggrams

Candiie · 2016-10-26T10:04:10Z

docs/DeveloperGuide.md

@@ -126,8 +126,8 @@ The `UI` component,

 The `Model`,


Similar for the image here ~ I'm seeing Tag Person ~ Name phone addy, email ~

U updated the text for Read Only Task below but not the image ~ so do take note of this too :)

Candiie · 2016-10-26T10:41:11Z

docs/DeveloperGuide.md

+5. Customize commands to suit user preference
+6. Able to toggle layout for dark and light for colour blindness
+7. Issue reminders for upcoming tasks
+8. Auto-complete functionality for user entries


hmmmmmmmmm....... this too i don't this this is a NFR ~ unless u are justifying it as "Efficiency?" do think about it and know how to justify your stand if u were questioned.

Otherwise, I do suggest this to be taken aaway ~

Candiie · 2016-10-26T10:42:50Z

docs/DeveloperGuide.md

+6. Able to toggle layout for dark and light for colour blindness
+7. Issue reminders for upcoming tasks
+8. Auto-complete functionality for user entries
+9. Google search function in CMDo

 {More to be added}


rmv this is u don't have any more to add ~ make sure ur User stories matches ur Use Cases~

Candiie · 2016-10-26T10:45:58Z

docs/DeveloperGuide.md

@@ -300,11 +549,56 @@ Use case ends.

 > Windows, Linux, Unix, OS-X

-##### Private contact detail
+## Appendix E : Product Survey


Wow @team, in general I do like how u guys tried to survey the products with the approach of how you can compare it to the features/functionalities in the app you are building! Great Job! This is how product surveys should be done!!!

However since this is to be added into the report I do urge you guys to add a few more observations ~

bcos ~ although it may not seem so, product evaluation is one of the most important part of software engineering ~ you learn from other peoples' failures and can try to improve your app by not making the same mistakes

Candiie · 2016-10-26T10:49:30Z

docs/DeveloperGuide.md

+4. Can share with another person via email.
+
+**CONS**
+1. 


really? no cons? if i can list one r u gonna do 100 push up for me :)

Candiie · 2016-10-26T10:51:12Z

docs/UserGuide.md

+Redo the earlier action.
+Format: `redo`
+
+#### Change the storage location : `storage`


do rmb to update ur user guide too if needed along side with ur implmentations~ great job updating the block and find :)

njyjn and others added 30 commits October 6, 2016 23:46

Merge branch 'about-us'

43d4f08

AboutUs finalized. Merged by Justin.

Renamed ChiangWengKiat.jpg for AboutUs.

8b2d7a8

Added screenshot files for UserGuide.

86e1755

Fixed a jpg extension error on CWK profile picture.

38b41eb

UserGuide v1 complete! Yay!

7d3f9aa

Added missing screenshots to UserGuide.

e2716dd

Corrected a minor error in UserGuide.

5471623

Updated README.md

4a3fa70

Merge branch 'UserGuide'

407a957

v0.0.1 finalized. Merged by Justin.

Added Candiie

3e89ef0

Merge branch 'about-us'

2138702

Fixed Candiie's profile picture

10f6f53

Tags have been modified to accomodate '-' instead of 't/'

92350cf

Refactored PERSON... into TASK

f916c2a

Created new regex string for data arguments format. To test.

6f47c2c

We modify pattern matcher grouping to fit our new regex.

c384aa2

We have begun refactoring instances of AddressBook, Person(s).

e5ed994

Refactoring part 2.

1e14354

Refactoring part 3.

cdf6b59

Refactoring part 4.

2849ed7

Refactoring part 5.

e4c7cad

Wrote some tests for adding tasks.

2f0c13a

Refractored Model from person to task

d74a807

Refactored to DueByDate and DueBytime

603027b

Merge pull request #15 from CS2103AUG2016-F11-C2/task

7db6b28

Ready to merge. Please note that we use ToDoList in place of TaskManagert—I will manually cherrypick.

Critical refactoring changes for ADF commands.

f596c91

Merge pr #15 to implement Tasks.

e4ae5cd

Refactoring part 6.

951dfea

Refactoring tests.

e95ebe9

Add UI layouts and CSS

b17b9b1

wengkiat and others added 27 commits October 20, 2016 13:06

typical test task for block command test

ad0e438

Merged branch BlockFunction into BlockFunction

ec82494

Merged branch BlockFunction into BlockFunction

9d5a79c

Added list functionality for block.

f490a9a

Attempt to resolve stash error.

b6c6f4c

Removed message cannot done temporarily.

30351cd

Added message cannot done again. Stash error resolved.

cb42aa4

Blocked check functionality now works with Add.

6c5d422

edited message to sound better and fix test

94cac1b

edited message to fix test

d2a0eb2

New test case to see if you can add a task to a blocked timeslot

16e5a94

new task test for testing

4214829

Full add/block functionality implemented.

fa6e503

Updated developer guide to reflect new block function

8a196b7

Updated user guide to reflect new block function

7623af5

Implemented command and logic.

de7380e

We'll use an event listener to dynamically save to userPrefs file and…

f21ab67

… update.

Merge pull request #40 from CS2103AUG2016-F11-C2/BlockFunction

0b4cda6

Good work.

Added attributions.

43f9503

Merge remote-tracking branch 'refs/remotes/origin/v0.3'

72c38a8

Conflicts: src/main/java/seedu/cmdo/commons/core/Config.java

Updated guides for storage.

cfb27db

Classpath now directs to bin where .jar file is found.

ed69bbc

Ensures that filepath links to local directory.

9df3300

Fixes LogicManagerTest, relegating it to test for fail messages only.

85d41e1

Changed the way tasks are compared.

f98136b

All tests passing for v0.3.

fa9b249

Removed ParserTest, GUI tests are sufficient.

c8629cd

nus-se-pr-bot assigned Candiie Oct 21, 2016

Candiie reviewed Oct 26, 2016

View reviewed changes

Candiie added the Reviewed label Oct 26, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[T9][F11-C2] #177

[T9][F11-C2] #177

njyjn commented Oct 21, 2016

Candiie left a comment

Candiie Oct 26, 2016

Candiie Oct 26, 2016

Candiie Oct 26, 2016

Candiie Oct 26, 2016

Candiie Oct 26, 2016

Candiie Oct 26, 2016

Candiie Oct 26, 2016

Candiie Oct 26, 2016

Candiie Oct 26, 2016

Candiie Oct 26, 2016

Candiie Oct 26, 2016

Candiie Oct 26, 2016

Candiie Oct 26, 2016

Candiie Oct 26, 2016

		@@ -113,7 +113,7 @@ The `UI` component,

		API : [`Logic.java`](../src/main/java/seedu/address/logic/Logic.java)

		@@ -113,7 +113,7 @@ The `UI` component,

		API : [`Logic.java`](../src/main/java/seedu/address/logic/Logic.java)

		1. `Logic` uses the `Parser` class to parse the user command.

[T9][F11-C2] #177

Are you sure you want to change the base?

[T9][F11-C2] #177

Conversation

njyjn commented Oct 21, 2016

Candiie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment