Improved Matlab compatibility #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the documentation of MATLAB on ellipke and ellipj, we see that the inputs to these functions can also be arrays. In the current implementation, we have to use the dot syntax to broadcast if we have an array of input values. However, this broadcasting syntax will lead to an array of tuples, which differs from that of MATLAB (tuple of arrays). Thus, I try to improve MATLAB compatibility by providing methods that accept array inputs directly.
Note that this PR does not comprise backward compatibility of this package, since I only add new methods. The implementation is rather simple and has been fully tested.