Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow types for onClone to return a promise #3162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukeapage
Copy link

Summary

onClone is returned to a promise, so returning a promise already works, but the type is void. Typescript does not error returning a promise today, but sonar qube does find a "bug" because it thinks you return a promise where you shouldn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant