fix: 🐛 handle content changes with overflow #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| // Don't access the `offsetWidth` multipe times since it triggers layout updates. | ||
| export function contentChange$(host: HTMLElement) { | ||
| return new Observable((subscriber) => { | ||
| const observer = new MutationObserver(() => { |
| return merge( | ||
| overflowChanges(this.host), | ||
| // We need to handle cases where the host has a static width but the content might change | ||
| this.contentChanged.asObservable().pipe( |
There was a problem hiding this comment.
Do we really need it always or it can be set via input?
shaharkazaz
force-pushed
the
fix/handle-content-changes-with-overflow
branch
2 times, most recently
from
7140f44
to
f5bdb35
Compare
shaharkazaz
force-pushed
the
fix/handle-content-changes-with-overflow
branch
from
f5bdb35
to
ef3264b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information