Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New shop page #2340

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

New shop page #2340

wants to merge 4 commits into from

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 1, 2024

Embeds spreadshop, with some CSS customisation

🤫

@netlify /shop

Embeds spreadshop, with some CSS customisation
@ewels ewels requested a review from mashehu March 1, 2024 16:52
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for nf-core ready!

Name Link
🔨 Latest commit 63bc7d4
🔍 Latest deploy log https://app.netlify.com/sites/nf-core/deploys/66088e5ed13d790008ec1959
😎 Deploy Preview https://deploy-preview-2340--nf-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ewels ewels marked this pull request as draft March 1, 2024 16:53
@edmundmiller
Copy link
Contributor

Will this auto-redirect to the US shop? 🤔

@ewels
Copy link
Member Author

ewels commented Mar 1, 2024

Not sure, you tell me! https://deploy-preview-2340--nf-core.netlify.app/shop/

For me it's showing GBP, so it might be a bit funky.

I was also thinking about having a FAQ and stuff - so might be worth having our own landing page before going through to the shop pages. Could then have links to the different shop sites, along with some FAQ. What do you think?

@edmundmiller
Copy link
Contributor

I'm getting pounds 😞

Yeah that could work. I bet we could render one or the other based on location.

@ewels
Copy link
Member Author

ewels commented Mar 2, 2024

Ok, I googled a bit more and also came to the same conclusion - that the auto redirect wouldn't work.

Just put together an index page and then location-specific embed pages under a dropdown. This should be more reliable. Also the FAQ mean that people hopefully know what they're getting themselves into.

Let me know what you think.

Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks lovely now! Love the FAQ before a shop renders. I agree that should be more reliable.

@nvnieuwk
Copy link
Contributor

One small thing I've noticed is that by selecting the Belgium: Dutch Euro option, it actually displays the page in French (which can be an issue because not all Flemish people speak French fluently, asking for a friend 😁)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants