Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mybatis-spring-2.0.x (Java 8, Spring 5.x and Spring Batch 4.x) #177

Merged
merged 32 commits into from
Apr 30, 2017
Merged

mybatis-spring-2.0.x (Java 8, Spring 5.x and Spring Batch 4.x) #177

merged 32 commits into from
Apr 30, 2017

Conversation

pboonphong
Copy link
Member

@pboonphong pboonphong commented Dec 23, 2016

TODO:

  • Migrate to Java 8 as same as Spring 5.x.
  • Upgrade dependencies, align with Spring Platform.
  • Upgrade to JUnit 5
  • Wrap Log with Logger to support lambda expressions.
  • Verify test cases with AssertJ
  • Replace Mockrunner with Mockito 2.x or H2/HSQLDB (TBD) Keep Mockrunner -> see Consider to use Mockito instead of Mockrunner #167
  • Create branch 1.3.x, then merge pull request with master.

Release Date: After Spring 5.x and Spring Batch 4.x released

FIXME: Enable SqlSessionTemplateAsyncAfterCompletionTest after migrate BMUnitRunner to BMUnitExtenson

@pboonphong pboonphong added this to the 2.0.0 milestone Dec 23, 2016
@pboonphong pboonphong self-assigned this Dec 23, 2016
@pboonphong pboonphong changed the title 2.0.x Version 2.0.x (Java 8 and Spring 5.x) Dec 23, 2016
@pboonphong pboonphong changed the title Version 2.0.x (Java 8 and Spring 5.x) Next version: mybatis-spring-2.0.x (Java 8 and Spring 5.x) Dec 23, 2016
@pboonphong pboonphong added the enhancement Improve a feature or add a new feature label Dec 23, 2016
@pboonphong
Copy link
Member Author

Hi @emacarron,

It's been a long time. I'm working on next release of MyBatis-Spring based on Spring 5.x. New version of HibernateDaoSupport required access to SessionFactory, while MyBatis SqlSession do not supported. In addition, direct use of getSqlSession() make me wonder whether it's MyBatis SqlSession or Spring's managed SqlSessionTemplate.

Would you recall why we changing SqlSessionTemplate to SqlSession in following urls? There is no track on code.google.com. I afraid it might be important changes.

pboonphong@2a0ab16
pboonphong@e8d4adb

--
Best regards,
PB

@pboonphong pboonphong changed the title Next version: mybatis-spring-2.0.x (Java 8 and Spring 5.x) mybatis-spring-2.0.x (Java 8 and Spring 5.x) Mar 16, 2017
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--

Copyright 2010-2016 the original author or authors.
Copyright 2010-2017 the original author or authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some files have not changed so the year should keep in 2016

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 530e0bf was reverted.

@pboonphong pboonphong merged commit baa1316 into mybatis:master Apr 30, 2017
@pboonphong pboonphong deleted the 2.0.x branch April 30, 2017 09:07
@emacarron
Copy link
Member

Sorry for the late reply!!

Opposite to JdbcTemplate or HIbernateTemplate, SqlSessionTemplate is an SqlSession so there is no need to return the implementation (the template). The idea behind that is to make code as generic and simple as possible: no need to do specific code for mybatis-spring or to know the specific class that it uses.

I have seen you added a new method getSqlSessionTemplate() that returns de same instace that the existing getSqlSession method. I would not change that. Looks quite confusing having two methods for the same thing.

kazuki43zoo added a commit to kazuki43zoo/spring that referenced this pull request Apr 29, 2018
@kazuki43zoo kazuki43zoo changed the title mybatis-spring-2.0.x (Java 8 and Spring 5.x) mybatis-spring-2.0.x (Java 8, Spring 5.x and Spring Batch 4.x) Jan 22, 2019
pulllock pushed a commit to pulllock/mybatis-spring that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve a feature or add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants