-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mkdocs & rtfd build #564
base: main
Are you sure you want to change the base?
Conversation
FYI mkdocs now supports dark theme starting from 1.6.0/b5, so I flipped the switches to auto/system +picker — [DEMO] |
* Add auto mkdocs darkmode * Update mkdocs to v1.6.1
Just FYI: We're going to sunset this repo shortly once some work with migrating to django-waffle is completed, so I wouldn't spend a lot of time on improvements here. More info: The static configs and funnelcakes are no longer used. The only thing used currently is waffle switches which will be replaced with database-based switches with django-waffle. Then this repo will be archived and no longer used. |
@robhudson Yep, I'm aware, worry not — I'm basically trying (along with the sibling PR for gh-pages) to fix the publishing workflow to perhaps allow publishing the actual deprecation info to the docs sites too, if/when needed — not leaving behind two outdated docs deployments for an archived repo dangling around;) |
The docs are actually not even building for almost a year now:
It stopped without any apparent reason, so probably just adding the yaml config should fix the builds.
This PR also updates the mkdocs version to help with some dependency woes et al. to be super-uptodate to avoid any surprises. (Also to close #548 too.)
The
[email protected]
+[email protected]
log can be verified here for1847787
…The
[email protected]
log is here for0ea4e2b
…Building RTD previews for PRs would need to be enabled in its settings first (not sure if that wouldn't first expect working config anyhoo), but since this can't really break more it shouldn't be necessary.