Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pip-compile-multi #786

Merged
merged 11 commits into from
Mar 1, 2022
Merged

Move to pip-compile-multi #786

merged 11 commits into from
Mar 1, 2022

Commits on Jan 21, 2022

  1. Switch from pip-tools to pip-compile-multi

    * Switch to pip-compile-multi, splitting out dev deps from prod deps
    
      It's worked fine, albeit with a TODO in the Dockerfile to actually build a separate dev-specific image,
      which will come in a separate commit.
    
      Went with the pattern of auto-installing the dependency-management tool via the makefile. Will likely
      switch this to an alert + install instructions
    
      This change was needed because in-container compilation was failing and various pip+pip-tools versions attempted clashed due to
      ```
      TypeError: make_requirement_preparer() got an unexpected keyword argument 'wheel_download_dir'
      ```
      which may have been a chicken-and-egg problem, but was not worth solving when a simpler route was around.
    
    * Rebuild requirements on the host, not in the container, but retain Makefile commands as the primary
      invocation route - `make compile-requirements` and  `make upgrade-requirements`
    stevejalim committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    24b9827 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Update makefile-driven UX around compiling and upgrading using pip-co…

    …mpile-multi
    
    Now, instead of force-intalling pip-compile-multi, we get a prompt showing us what do to (and so providing some flexibility)
    
    Also note that some dev subdeps have been minorly bumped.
    
    IMPORTANT: if you currently try to recompile deps results in a failure with long-unmaintained suds-jurko, so this will need swapping out. The current set of deps builds and passes tests, at least
    stevejalim committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    d0d5548 View commit details
    Browse the repository at this point in the history
  2. Drop Salesforce-FuelSDK from imports

    No longer needed and was causing a dependency install issue due to its suds-jurko subdep
    stevejalim committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    5c4d746 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    534668b View commit details
    Browse the repository at this point in the history
  4. Add make command for checking for stale dependencies

    Invoke with:
    
       $ make check-requirements
    
    and update hard-pinned dependencies as you wish
    stevejalim committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    f0f436d View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Refactor to run pip-compile-multi within the docker container

    This gives us guaranteed install stability regardless of the source platform being used to run the update
    
    Note that pip-tools and pip-compile-multi are installed ONLY for compiling or upgrading requirements, rather than adding them to the main build.
    pip-tools needed pinning to a recent version to get around incompatibility issues with pip 21 and pip-tools.
    stevejalim committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    8afc1b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7b08f24 View commit details
    Browse the repository at this point in the history
  3. Typo fix in docs

    stevejalim committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    06833cb View commit details
    Browse the repository at this point in the history
  4. Remove make docs from top-level Makefile, because it fails

    One can still compile the docs by using the Makefile in /docs and issuing
    
      $ make clean html
    stevejalim committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    d1657cf View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Update requirements build script

    * hard-pin latest working combo of pip, pip-tools and pip-compile-multi
    * add in custom header to make recompliation step unambiguous
    * update Makefile: remove unneeded upgrade-requirements option; update help
    * recompile reqs with minor bumps
    stevejalim committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    20b1027 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Configuration menu
    Copy the full SHA
    b4f19d4 View commit details
    Browse the repository at this point in the history