[Editor] Avoid to have a selected stamp annotation on top of the secondary toolbar (bug 1911980)

[calixteman]

And I changed the permissions on the images to remove the x flag which is useless.

[calixteman]

/botio integrationtest

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/38fac76a2e26c94/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7bf1323c56bb6bc/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/7bf1323c56bb6bc/output.txt

Total script time: 9.44 mins

• Integration Tests: Passed

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/38fac76a2e26c94/output.txt

Total script time: 19.35 mins

• Integration Tests: FAILED

[Snuffleupagus]

Pretty please test these sort of changes affecting the viewer more thoroughly during development, to save my time have to re-review stuff.

[calixteman]

I'm using the dark mode and this kind of difference is almost invisible for me.

That said, it's unrelated to this patch but I think the sidebar should live either under the toolbar or just after it, because if the user clicks or on the toggle sidebar button and then hit then the focus is moving on the toolbar, then the pages, then the firefox ui and finally the sidebar.
In Edge, the focus moves on the sidebar when in Chrome it moves on the toolbar and then on the sidebar.
I'll file a bug and see what the a11y team thinks about that.

[calixteman]

I think it should safe: finally the patch just changes the current z-index values we've but in keeping the same order and just add a new one for the viewer container to make sure it's behind the sidebar and the toolbar.

[Snuffleupagus]

Should we perhaps also implement the suggestion from #18793 (comment), although not technically needed here, since having a hard-coded colour seems generally wrong?

[Snuffleupagus]

/botio-linux preview

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/0445fda180a9bdc/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/0445fda180a9bdc/output.txt

Total script time: 1.09 mins

Published

• Viewer: http://54.241.84.105:8877/0445fda180a9bdc/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/0445fda180a9bdc/legacy/web/viewer.html

[Snuffleupagus]

r=me, hopefully we've found all regressions now; thank you.