Fixed annotation getting rotated when moving between pages

[pilipovicmilan04]

BUG: It has an issue that dragging an ink annotation between rotated pages causes weird behavior.

How to reproduce:
Open this pdf https://github.com/mozilla/pdf.js/blob/master/test/pdfs/rotation.pdf
Draw ink annotation
Try to drag the ink annotation between rotated pages and it will not work properly.

pdf4.webm

[Snuffleupagus]

It has an issue that dragging an ink annotation between rotated pages causes weird behavior.

Is this actually specific to the InkEditor though, since it seems that all Editors are similarly affected?

Also, so that this can be reviewed, please squash the commits such that the commit history is clean.

[pilipovicmilan04]

Is this actually specific to the InkEditor though, since it seems that all Editors are similarly affected?

Also, so that this can be reviewed, please squash the commits such that the commit history is clean.

Seems others are also not working. Checking if I can fix them. @Snuffleupagus

[calixteman]

Firstly, thank you for your contribution and for having found this bug.
It'd be nice to add some integration tests.
You can try in using the rotation.pdf file, in setting the odd spread mode (to have the two pages in the viewport) and in setting zoom to pageFit (which is the default with integration tests).
You can use dragAndDropAnnotation function.

[pilipovicmilan04]

Fixed for all editor types @Snuffleupagus @calixteman

[pilipovicmilan04]

Just to know, is there any other way to fix this issue? I'd like to know if there's any other optimized way to do this. @calixteman @Snuffleupagus It would be great to get your feedback on my solution 🙏

[calixteman]

You can simplify the two cases 90 and 270 in using newRotation % 180 !== 0

[calixteman]

I added some code to change the spread mode when loading the pdf in the integration tests:
https://github.com/mozilla/pdf.js/pull/18275/files#diff-6ead6f27780ca257e3f28e9f66dac1b8d6b5af135e4bf4e8ae0844dc37540caeR758-R768

[calixteman]

Just to know, is there any other way to fix this issue? I'd like to know if there's any other optimized way to do this. @calixteman @Snuffleupagus It would be great to get your feedback on my solution 🙏

Overall, it looks good to me but with a test for freetext and ink annotations.
Once the tests are written I'll review your patch.