Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Django 4.2.x and Python 3.12.x #843

Merged
merged 16 commits into from
Jan 25, 2024
Merged

Conversation

stevejalim
Copy link
Contributor

This changeset moves Nucleus up to Python and Django versions that are not too close to EOL.

The move to Python 3.12.1 also meant moving away from gunicorn+meinheld, as meinheld won't compile above Python 3.9

While in the neighbourhood, I've also switched to ruff from isort + flake8

To test:

  • check out branch
  • make clean build test
  • docker-compose up web
  • make run-shell then ./manage.py createsuperuser to be able to log in
  • Go to http://localhost:8000 and log in to the nucleus admin
  • add a release or two, with some notes to confirm all works ok

Other considerations:

  • We can also test this on nucleus dev once it's hit master, but there's no test env. Suggestions/recollections for how this has been tested in the past are welcome.

Dockerfile Outdated Show resolved Hide resolved
nucleus/base/admin.py Outdated Show resolved Hide resolved
Copy link
Member

@robhudson robhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

@stevejalim stevejalim added the maintenance Stuff we just gotta do label Jan 9, 2024
Copy link
Member

@robhudson robhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🥳

@stevejalim stevejalim merged commit 3ff9cc9 into master Jan 25, 2024
2 checks passed
@stevejalim stevejalim deleted the django-4-python-3-12 branch January 25, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Stuff we just gotta do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants