Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support associating release notes with one or more countries #827

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

stevejalim
Copy link
Contributor

@stevejalim stevejalim commented Nov 23, 2023

Nucleus-side work towards #827

Adds a Country model, backfills it with data and adds a relevant_countries field to Note model

The representation of a Note in the all-releases.json now features a relevant_countries key, which has a list of dicts:

     {
        "id": 7,
        "bug": null,
        "note": "Elit id consequat, occaecat cillum. Occaecat cillum, ipsum quis. Quis laboris, dolor amet nisi aliquip velit consequat. Amet nisi aliquip velit consequat officia ipsum duis. Aliquip velit consequat officia ipsum, duis id amet.",
        "tag": "",
        "sort_num": 0,
        "is_public": true,
        "progressive_rollout": false,
        "relevant_countries": [
          {
            "name": "Angola",
            "code": "AO"
          },
          {
            "name": "Anguilla",
            "code": "AI"
          },
          {
            "name": "Antarctica",
            "code": "AQ"
          }
        ],
        "created": "2023-11-23T15:20:58.814643+00:00",
        "modified": "2023-11-23T16:03:18.389135+00:00"
      }

And this is present but empty if there are no specifically-associated countries:

        "relevant_countries": [],

--

There will be complementary work on the Bedrock side to read in this data

@stevejalim stevejalim changed the title Add Country model, backfill with data and add relevant_countries field to Note model Support associating release notes with one or more countries Nov 26, 2023
Copy link
Member

@robhudson robhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me

@stevejalim stevejalim merged commit fd3298c into master Nov 28, 2023
2 checks passed
@stevejalim stevejalim deleted the 811-add-geo-labels-to-notes branch November 28, 2023 22:05
@stevejalim
Copy link
Contributor Author

For the record, mozilla/bedrock#13931 is the mozorg-side code change to show this data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants