Skip to content

Commit

Permalink
Add new 'Reviewed by release manager' flag on Release - for Nucleus-s…
Browse files Browse the repository at this point in the history
…ide information only (#825)

The field, reviewed_by_release_manager, will appear in JSON API data, but
Bedrock will skip it because it doesn't map to a field known by Bedrock. (And
this is fine - we don't need to think about it in Bedrock)
  • Loading branch information
stevejalim authored Nov 20, 2023
1 parent 8657f34 commit 96f331a
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 1 deletion.
13 changes: 12 additions & 1 deletion nucleus/rna/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,18 @@ class ReleaseAdminForm(forms.ModelForm):

class Meta:
model = models.Release
fields = ("is_public", "product", "channel", "version", "release_date", "text", "bug_list", "bug_search_url", "system_requirements")
fields = (
"is_public",
"product",
"channel",
"version",
"release_date",
"text",
"bug_list",
"bug_search_url",
"system_requirements",
"reviewed_by_release_manager",
)


class ReleaseAdmin(admin.ModelAdmin):
Expand Down
17 changes: 17 additions & 0 deletions nucleus/rna/migrations/0007_release_reviewed_by_release_manager.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Generated by Django 3.2.23 on 2023-11-20 22:25

from django.db import migrations, models


class Migration(migrations.Migration):
dependencies = [
("rna", "0006_note_progressive_rollout"),
]

operations = [
migrations.AddField(
model_name="release",
name="reviewed_by_release_manager",
field=models.BooleanField(default=False, help_text="Purely a visual indicator in Nucleus - does not show on mozilla.org", null=True),
),
]
5 changes: 5 additions & 0 deletions nucleus/rna/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ class Release(SaveToGithubModel):
bug_list = models.TextField(blank=True)
bug_search_url = models.CharField(max_length=2000, blank=True)
system_requirements = models.TextField(blank=True)
reviewed_by_release_manager = models.BooleanField(
null=True,
default=False,
help_text="Purely a visual indicator in Nucleus - does not show on mozilla.org",
)

objects = ReleaseManager()

Expand Down

0 comments on commit 96f331a

Please sign in to comment.