Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distribution_id to feature_usage_events_v1 #6277

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

m-d-bowerman
Copy link
Contributor

@m-d-bowerman m-d-bowerman commented Sep 30, 2024

Description

This PR adds the client distribution_id. This is necessary to count app push notification events and set to default events to support mobile distribution deals.

Adds engagement with the sponsored tiles feature.

┆Issue is synchronized with this Jira Task

@m-d-bowerman
Copy link
Contributor Author

Waiting on @rhythmofrain63 for confirmation that the changes won't break downstream dependencies when grouping by distribution_id.

@dataops-ci-bot

This comment has been minimized.

@dataops-ci-bot
Copy link

Integration report for "add sponsored tiles usage"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/feature_usage_events_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/feature_usage_events_v1/query.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/feature_usage_events_v1/query.sql	2024-09-30 21:24:32.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/feature_usage_events_v1/query.sql	2024-09-30 21:24:27.000000000 +0000
@@ -30,6 +30,7 @@
     client_id,
     channel,
     adjust_network,
+    distribution_id
   FROM
     `moz-fx-data-shared-prod.fenix.firefox_android_clients`
 ),
@@ -330,7 +331,15 @@
     COUNTIF(
       event_category = 'home_screen'
       AND event_name = 'customize_home_clicked'
-    ) AS home_page_customize_home_clicked
+    ) AS home_page_customize_home_clicked,
+    COUNTIF(
+      event_category = 'top_sites'
+      AND event_name = 'contile_click'
+    ) AS top_sites_contile_click,
+    COUNTIF(
+      event_category = 'top_sites'
+      AND event_name = 'contile_impression'
+    ) AS top_sites_contile_impression
   FROM
     `moz-fx-data-shared-prod.fenix.events_unnested`
   WHERE
@@ -938,7 +947,27 @@
       WHEN home_page_customize_home_clicked > 0
         THEN client_id
     END
-  ) AS home_page_customize_home_clicked_users
+  ) AS home_page_customize_home_clicked_users,
+  distribution_id,
+/*Sponsored Tiles*/
+--top_sites_contile_click
+  SUM(top_sites_contile_click) AS top_sites_contile_click,
+  COUNT(
+    DISTINCT
+    CASE
+      WHEN top_sites_contile_click > 0
+        THEN client_id
+    END
+  ) AS top_sites_contile_click_users,
+--top_sites_contile_impression
+  SUM(top_sites_contile_impression) AS top_sites_contile_impression,
+  COUNT(
+    DISTINCT
+    CASE
+      WHEN top_sites_contile_impression > 0
+        THEN client_id
+    END
+  ) AS top_sites_contile_impression_users,
 FROM
   event_ping_clients_feature_usage
 INNER JOIN
@@ -956,4 +985,5 @@
   channel,
   country,
   adjust_network,
-  is_default_browser
+  is_default_browser,
+  distribution_id
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/feature_usage_events_v1/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/feature_usage_events_v1/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/feature_usage_events_v1/schema.yaml	2024-09-30 21:24:32.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix_derived/feature_usage_events_v1/schema.yaml	2024-09-30 21:24:27.000000000 +0000
@@ -521,3 +521,18 @@
 - name: home_page_customize_home_clicked_users
   type: INTEGER
   mode: NULLABLE
+- name: distribution_id
+  type: STRING
+  mode: NULLABLE
+- name: top_sites_contile_click
+  type: INTEGER
+  mode: NULLABLE
+- name: top_sites_contile_click_users
+  type: INTEGER
+  mode: NULLABLE
+- name: top_sites_contile_impression
+  type: INTEGER
+  mode: NULLABLE
+- name: top_sites_contile_impression_users
+  type: INTEGER
+  mode: NULLABLE

Link to full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants