Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waffles Part 2: Move waffle switches to django-waffle 🧇 #15229

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

robhudson
Copy link
Member

One-line summary

See #15195 for Part 1.

This is Part 2 after Part 1 is deployed and the import has been run.

  • I used an AI to write some of this code.

Significant changes and points to review

Issue / Bugzilla link

#15157

Testing

@robhudson robhudson changed the title Move waffle switches to django-waffle 🧇 Waffles Part 2: Move waffle switches to django-waffle 🧇 Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 42.30769% with 15 lines in your changes missing coverage. Please review.

Project coverage is 78.34%. Comparing base (2df9c9b) to head (ba611bd).

Files with missing lines Patch % Lines
...base/management/commands/import_waffle_switches.py 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15229      +/-   ##
==========================================
+ Coverage   77.88%   78.34%   +0.45%     
==========================================
  Files         163      162       -1     
  Lines        8480     8358     -122     
==========================================
- Hits         6605     6548      -57     
+ Misses       1875     1810      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robhudson robhudson force-pushed the 15157-mv-to-django-waffle-part-2 branch from 2336f0b to ba611bd Compare October 1, 2024 00:41
@robhudson
Copy link
Member Author

@stevejalim, @pmac Flagged for review, but probably best to review by commit since this branch is based on the part-1 branch. So you'll see both in the "Files changed" view.

Copy link
Member

@pmac pmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants