Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newsletter form to nothing-personal page (Fixes #15218) #15223

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

alexgibson
Copy link
Member

One-line summary

Adds a newsletter form to the bottom of /firefox/nothing-personal/.

Issue / Bugzilla link

#15218

Testing

http://localhost:8000/en-US/firefox/nothing-personal/

@alexgibson alexgibson added P2 Second level priority - Should have Needs Review Awaiting code review Review: XS Code review time: up to 30min Do Not Merge ⚠️ labels Sep 30, 2024
@alexgibson alexgibson marked this pull request as ready for review September 30, 2024 09:11
@alexgibson
Copy link
Member Author

This is ready for code review, but marking as do-not-merge for now until we get sign-off that things are ready.

Copy link
Contributor

@reemhamz reemhamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works great. r+
I'll leave this for you to merge when you get the final go-ahead 👍🏼

@reemhamz reemhamz removed the Needs Review Awaiting code review label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.89%. Comparing base (dee5f9f) to head (3ce51e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15223   +/-   ##
=======================================
  Coverage   77.88%   77.89%           
=======================================
  Files         163      163           
  Lines        8480     8483    +3     
=======================================
+ Hits         6605     6608    +3     
  Misses       1875     1875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but it took a moment to wrap my head around it. Maybe some comment or tweaking a var name would help our future selves?

r+wc

bedrock/newsletter/forms.py Outdated Show resolved Hide resolved
bedrock/newsletter/forms.py Outdated Show resolved Hide resolved
@alexgibson alexgibson merged commit 1b7c5d3 into mozilla:main Oct 1, 2024
4 checks passed
@alexgibson alexgibson deleted the nothing-personal-email branch October 1, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Second level priority - Should have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants