Migrate remaining VPN Selenium tests to Playwright #14904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14904 +/- ##
=======================================
Coverage 77.88% 77.88%
=======================================
Files 163 163
Lines 8480 8480
=======================================
Hits 6605 6605
Misses 1875 1875 ☔ View full report in Codecov by Sentry. |
alexgibson
added
Needs Review
alexgibson
force-pushed
the
playwright-vpn
branch
2 times, most recently
from
7081513
to
bd698d5
Compare
alexgibson
force-pushed
the
playwright-vpn
branch
from
bd698d5
to
12d8ea6
Compare
alexgibson
force-pushed
the
playwright-vpn
branch
3 times, most recently
from
2f4ff6a
to
406dcd1
Compare
alexgibson
force-pushed
the
playwright-vpn
branch
2 times, most recently
from
d8352a3
to
b685514
Compare
alexgibson
force-pushed
the
playwright-vpn
branch
2 times, most recently
from
ff94529
to
c319715
Compare
alexgibson
force-pushed
the
playwright-vpn
branch
from
c319715
to
a52a413
Compare
reemhamz
approved these changes
Sep 30, 2024
| const { test, expect } = require('@playwright/test'); | ||
| const openPage = require('../../../scripts/open-page'); | ||
| const url = '/en-US/products/vpn/features/'; | ||
| const availableCountries = ['us', 'ca', 'gb', 'de', 'fr']; |
There was a problem hiding this comment.
Question: there are more countries where VPN is available in. Is this just a sample list to run the tests on some locations?
There was a problem hiding this comment.
The landing page experience is the same for all countries where VPN is available for, so I don't think it adds much to repeat the same test dozens of times. I think these core countries should be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Add remaining tests for legacy VPN landing/pricing pages, as well as features page.
Issue / Bugzilla link
N/A
Testing
Successful test run: https://github.com/mozilla/bedrock/actions/runs/10159829857