Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): added BundleSize section #722

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

lucacacciarru
Copy link
Collaborator

Proposed changes

Added BundleSize section
WIP #707

Types of changes

  • πŸ› Bugfix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality or enhancements)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • βœ… Tests (added tests for an existing feature)
  • πŸ“š Documentation Update (if none of the other choices apply)
  • πŸ™Œ Other (please, write a clear and concise description of the proposal in the section above)

Checklist

  • πŸ‘€ I have read the CONTRIBUTING doc
  • βœ… Lint and unit tests pass locally with my changes
  • πŸ§ͺ I have added tests that prove my fix is effective or that my feature works
  • πŸ“š I have added the necessary documentation (if appropriate)
  • πŸ”€ Any dependent changes have been merged and published in downstream modules

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023

⚠️ No Changeset found

Latest commit: 4e83d6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@mauroerta mauroerta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mauroerta mauroerta merged commit 431b732 into main Apr 26, 2023
@mauroerta mauroerta deleted the feat/bundleSize_docs_section branch April 26, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants