Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: incorrectly attempting access to sign release artifacts variables #694

Merged
merged 36 commits into from
May 29, 2024

Conversation

aditi-khare-mongoDB
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB commented May 28, 2024

Description

Before this fix, the access to the steps.<step_id_name>.outputs.<vars_name> was incorrectly formatted.
This is a very small change (pay no mind to the 36 commits, that's just due to the same branch name being reused).

What is changing?

gh release upload now has the correct files, as does garasign.

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Bug fix for SSDLC.

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@aditi-khare-mongoDB aditi-khare-mongoDB changed the title Node 6156/sign release artifacts temp test fix: sign release artifacts variable incorrect access May 28, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB marked this pull request as ready for review May 28, 2024 20:55
@aditi-khare-mongoDB aditi-khare-mongoDB changed the title fix: sign release artifacts variable incorrect access fix: sign release artifacts variable incorrectly accessed May 28, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB changed the title fix: sign release artifacts variable incorrectly accessed fix: incorrectly access sign release artifacts variables May 28, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB changed the title fix: incorrectly access sign release artifacts variables fix: incorrectly attempting access to sign release artifacts variables May 28, 2024
@W-A-James W-A-James self-assigned this May 29, 2024
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 29, 2024
@W-A-James W-A-James changed the title fix: incorrectly attempting access to sign release artifacts variables chore: incorrectly attempting access to sign release artifacts variables May 29, 2024
@W-A-James W-A-James merged commit 8c760d1 into main May 29, 2024
8 checks passed
@W-A-James W-A-James deleted the NODE-6156/sign-release-artifacts branch May 29, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants