fix: remove compass-preferences from connection-form completely COMPASS-8098 #6294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
approved these changes
Sep 27, 2024
| connectionColorToHex: isMultiConnectionEnabled | ||
| ? newColorCodeToHex | ||
| : colorCodeToHex, | ||
| connectionColorToHex: newColorCodeToHex, |
There was a problem hiding this comment.
[nit] Does it make sense to drop the new now?
| return; | ||
| } | ||
|
|
||
| const migratedColor = legacyColorsToColorCode(colorCode); |
There was a problem hiding this comment.
We only have one other use of legacyColorsToColorCode, and it's in the color picker. Maybe we can remove legacyColorsToColorCode and LEGACY_COLORS_TO_COLOR_CODE_MAP now? Someone would be using a color from ~3 years ago, and we'd only slightly be helping them select a color inside of the color picker UI.
There was a problem hiding this comment.
that must be part of the legacy bits. I'll try to remove it + the parts that use it, hopefully it's not too deep of a rabbit hole 🤞
paula-stacho
force-pushed
the
COMPASS-8089-2
branch
from
49399e2
to
237ac91
Compare
paula-stacho
force-pushed
the
COMPASS-8089-2
branch
from
237ac91
to
435fdb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing last reference to compass-preferences from connection-form, because it's causing some issues in the VSCode integration.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes