Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#ifdef SMALLTABLES
change eliminates the unused variable warning, and the changes to thesc25519_window4
prototype silences the-Wstringop-overflow=
warnings in GCC.The prototype seems to be wrong b/c it requires an array of size 85, but the function definition only uses 64 bytes, the caller expects it only needs 64 bytes, and the 85 seems to be a copy/paste issue from window3 (Props to @moneromooo-monero for finding that)
Closes #7 and #8