Implement ElectrumWords::get_invalid_word #9466
Open
+112
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New error message with specific invalid word is displayed
|
|
Old error message is displayed on checksum failure
|
sneurlax
reviewed
Sep 5, 2024
| @@ -371,6 +371,59 @@ namespace crypto | |||
| return true; | |||
| } | |||
|
|
|||
| std::string get_invalid_word(const epee::wipeable_string &words) | |||
| { | |||
| // If there's a new language added, add an instance of it here. | |||
There was a problem hiding this comment.
It might be worth the additional diff to find where else language lists are defined and leave a comment directing devs here for language-related work
sneurlax
approved these changes
Sep 5, 2024
|
... but ... I actually have to recheck if this is really needed. I forgot that only the first 3 letters really matter... This might still be helpful |
|
|
? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes monero-project/monero-gui#4342
Please review and feedback