bump lmdb sync threshold for performance #8839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force sync every 100k blocks instead of every 1k blocks. Bumping this value is reported to make a big difference in sync performance, eg: monero-project#8189
|
Is it known why Windows corrupts more often for unsynced writes than other operating systems? |
jeffro256
approved these changes
May 7, 2023
hyc
approved these changes
May 8, 2023
|
@jeffro256 many reasons; primarily it's simply a more unstable OS and prone to spontaneous OS crashes. Also its users are generally less sophisticated, and will more often e.g. disconnect an external drive without safely unmounting/ejecting it first. |
| @@ -576,7 +576,11 @@ namespace cryptonote | |||
| else if(options[0] == "fastest") | |||
| { | |||
| db_flags = DBF_FASTEST; | |||
| #ifdef _WIN32 | |||
There was a problem hiding this comment.
so its me and I really don't know what im doin..
but does PR #8848 do something to this ifdef _win32 thing? or is it still fine and dandy somehow.
There was a problem hiding this comment.
unrelated, _WIN32 is always available
|
rightio. |
|
wait i think i hit a wrong button. sorry. i'll move away from the keyboard now. |
selsta
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force sync every 100k blocks instead of every 1k blocks. Bumping this value is reported to make a big difference in sync performance, eg: #8189