wallet: can't decrypt payment id if tx key is missing

monero-project · Sep 26, 2024 · 31c6b2a · 31c6b2a
1 parent a1dc85c
commit 31c6b2a
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/wallet/wallet2.cpp b/src/wallet/wallet2.cpp
@@ -7502,6 +7502,11 @@ crypto::hash wallet2::get_payment_id(const pending_tx &ptx) const
         MWARNING("Encrypted payment id found, but no destinations public key, cannot decrypt");
         return crypto::null_hash;
       }
+      if (ptx.tx_key == crypto::null_skey)
+      {
+        MWARNING("Encrypted payment id found, but no tx secret key, cannot decrypt");
+        return crypto::null_hash;
+      }
       if (m_account.get_device().decrypt_payment_id(payment_id8, ptx.dests[0].addr.m_view_public_key, ptx.tx_key))
       {
         memcpy(payment_id.data, payment_id8.data, 8);