CMAKE problem liblo OSC 20240821

[Eve00000]

CMAKE problem liblo OSC 20240821
CMakeLists.txt
FindLiblo.cmake.txt

I renamed FindLiblo.cmake to FindLiblo.cmake.txt because *.cmake is not supported

[daschuer]

The file itself needs to be with lower l as well.

[daschuer]

Suggested change

	NAMES liblo/liblo.h
	NAMES lo/lo.h

[daschuer]

Suggested change

	NAMES liblo
	NAMES lo

[daschuer]

After these changes it works for me.

[Eve00000]

This branch also contains commits form Antoine's stem branch. You can get rid of them by git rebase --onto upstream/main b0d0e1938f1d024618f7522f3f788b9bacf378af

Which git tool do you used? I use SmartGit and the command line. When I started with git, this game like tutorial was helpful to me: https://learngitbranching.js.org

I will now try to build your branch.

Thank you, at the moment just git cli, it's true: I loose a lot of time with git things. I already read a lot of manuals and online tutorials, but I'm still mixing up. I stil type compuserve, unix and bb commands (from 30+ years ago).
Smartgit is a gui !! wow, I'll try, another thank you.
where does the nr (b0d0e19) come from?

[Eve00000]

Installing the liblo package (.\vcpkg\vcpkg install liblo) gave a 'vcpkg error in triplet x64 .... unable to find a valid visual studio instance on location ....
I found a github vcpkg issue with 'some kind" of solution.
I reïnstalled (visual studio installer unchecked, rechecked) the Windows Universal C Runtime and added the Microsoft.VisualStudio.Component.VC.140.

Now I am in the next phase ;-)
.\vcpkg\vcpkg install liblo gives a building error 'error: building liblo:x64-windows failed with: BUILD_FAILED'
20240825 - install liblo pck error.txt
and created some log files:

config-x64-windows-err.log
config-x64-windows-out.log
config-x64-windows-rel-CMakeCache.txt.log
error-logs-x64-windows.txt
extract-err.log
extract-out.log
stdout-x64-windows.log
config-x64-windows-dbg-CMakeCache.txt.log

[daschuer]

b0d0e19 is the old base commit.
The command means
git rebase --onto <new_base> <old_base>
the old base will be not part of the rebase brach.

[daschuer]

Installing the liblo package (.\vcpkg\vcpkg install liblo)

You may download the compiled package here https://github.com/mixxxdj/vcpkg/actions/runs/10541078514 So you may get around the VCPKG build step.

But it should work as well in a local build:

"C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64/cl.exe" is not able to compile a simple test program.

I wonder if you see the same issue when tryingto build mixxx?

I think you need to do all that from the "Developer Command Prompt for Visual Studio"

[Eve00000]

Thank you and hello
I already tried it in the visual studio developer command prompt and it gave the same error. (I learned to try in other cli's)
Building Mixxx (D:\mixxx-git\mixxx\build\x64__portable>cpack -wix) gives the same error, when I put # before the find_package and target Mixxx builds fine.
Do I have to download the 1.44 Gb file? And where do I have to put that?

[daschuer]

Do I have to download the 1.44 Gb file?

Yes. Normally it is downloaded via:
https://github.com/mixxxdj/mixxx/blob/main/tools/windows_buildenv.bat
But here you need a diffrent file.

I think it is unpacked to the "install" folder maybe it is the most traight forward solution to replace it into the same sub folder.
Alternatively you need to update the "MIXXX_VCPKG_ROOT" environment vairiable accordingly.

[daschuer]

Once mixxxdj/vcpkg#146 we can update windows_buildenv.bat that it works automatically without such a hassel for you.

[Eve00000]

Once mixxxdj/vcpkg#146 we can update windows_buildenv.bat that it works automatically without such a hassel for you.

No problem, I 'm learning a LOT about the whole structure/dependencies/architecture of Mixxx

[Eve00000]

so ....
Downloaded the mixxx-deps-2.5-x64-windows-0539f50.zip, inspected the windows_buildenv.bat and came to the conclusion it can't be done manually. So I replaced the name of the zip in the windows_buildenv.bat with the new name, calculated the sha256 and put it in the bat too .... all fine
Opening CMakeList.txt -> error line 53 "Did you download the Mixxx build environment using ${CMAKE_SOURCE_DIR}/tools/windows_buildenv.bat?" .....