Several fixes and improvements on the windows build environment #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated gitignore with current versions and several other corrections - Update lame target platform from v120 to v141 to ensure compilation. - removed the now unused build_qt4.bat and another mention of QT4 on create_environment.bat
- libsndfile solution was compiled in release mode when asked for debug - openssl set an erroneous target for debug - do not try to copy the dll for projects that don't generate dlls (rubberband and libsndfile).
- Added the compiler detection code on build_environment that was added to mixxx/build/appveyor/build_mixxx.cmd - Added multithreaded compiler settings. - Fixed QT5 download check (was checking for the tar.xz but was downloading the zip). - Implemented one-step decompression of tar.xz. Note: This should not be executed on a windows powershell but plain command prompt. If it is problematic, we can revert to the .zip download. - Copying zlibwapi.dll to QT bin dir if building dynamically.
Be-ing
reviewed
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes some cleanups of old values and files, some build fixes for debug compilation and some improvements on the detection of the compiler to use.
Check the commits for more details