Add support for CompletionList "applyKind" to control how defaults and per-item commitCharacters/data are combined #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d per-item commitCharacters/data are combined Implements the changes in the LSP spec PR at microsoft/language-server-protocol#2018. (Also see microsoft/language-server-protocol#1802)
|
@dbaeumer FYI in case you didn't see this :) Looks like one of the status checks is stuck too (not the approval one, but |
|
I was out the last 1 1/2 weeks. Will have a look this week. |
dbaeumer
requested changes
Sep 30, 2024
| * | ||
| * @since 3.18.0 | ||
| */ | ||
| export namespace ApplyKind { |
There was a problem hiding this comment.
I missed that on the spec side. Usually we only use string enums for enum kinds that are extensible from the server side and then type them as strings. To make things consistent I would say we should use numbers instead.
There was a problem hiding this comment.
Sure - I've pushed f8ed433 + 5e28745 with this change and some minor tweaks, and equiv changes in microsoft/language-server-protocol#2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the changes in the LSP spec PR at microsoft/language-server-protocol#2018 (see also microsoft/language-server-protocol#1802).
Please let me know if you think there are any additional test cases that need covering.