[tidy-html5] cmake find_package() support #41258
Open
+56
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree |
JonLiu1993
reviewed
Sep 30, 2024
| list ( APPEND add_LIBS ${name} ) | ||
| endif () | ||
| -install(TARGETS ${name} | ||
| +install(TARGETS ${name} EXPORT tidy-html5Config |
There was a problem hiding this comment.
Suggested change
| +install(TARGETS ${name} EXPORT tidy-html5Config | |
| +install(TARGETS ${name} EXPORT unofficial-tidy-html5Config |
There was a problem hiding this comment.
You can refer to this document to add CMake exports in unofficial namespaces https://github.com/microsoft/vcpkg-docs/blob/38e5ded0a49722b467ddfa1c75363c41d5107a0f/vcpkg/contributing/maintainer-guide.md#add-cmake-exports-in-an-unofficial--namespace
JonLiu1993
reviewed
Sep 30, 2024
| COMPILE_FLAGS "-DBUILD_SHARED_LIB -DBUILDING_SHARED_LIB") | ||
| - install(TARGETS ${name} | ||
| + target_include_directories( ${name} PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>) | ||
| + install(TARGETS ${name} EXPORT tidy-html5Config |
There was a problem hiding this comment.
Suggested change
| + install(TARGETS ${name} EXPORT tidy-html5Config | |
| + install(TARGETS ${name} EXPORT unofficial-tidy-html5Config |
JonLiu1993
reviewed
Sep 30, 2024
| +#------------------------------------------------------------------------ | ||
| +# CMake FIND_PACKAGE() Support | ||
| +#------------------------------------------------------------------------ | ||
| +install(EXPORT tidy-html5Config |
There was a problem hiding this comment.
Suggested change
| +install(EXPORT tidy-html5Config | |
| +install(EXPORT unofficial-tidy-html5Config |
JonLiu1993
reviewed
Sep 30, 2024
| +#------------------------------------------------------------------------ | ||
| +install(EXPORT tidy-html5Config | ||
| + DESTINATION ${LIB_INSTALL_DIR}/cmake/tidy-html5 | ||
| + NAMESPACE tidy-html5::) |
There was a problem hiding this comment.
Suggested change
| + NAMESPACE tidy-html5::) | |
| + NAMESPACE unofficial::tidy-html5::) |
JonLiu1993
reviewed
Sep 30, 2024
| +# CMake FIND_PACKAGE() Support | ||
| +#------------------------------------------------------------------------ | ||
| +install(EXPORT tidy-html5Config | ||
| + DESTINATION ${LIB_INSTALL_DIR}/cmake/tidy-html5 |
There was a problem hiding this comment.
Suggested change
| + DESTINATION ${LIB_INSTALL_DIR}/cmake/tidy-html5 | |
| + DESTINATION ${LIB_INSTALL_DIR}/cmake/unofficial-tidy-html5 |
JonLiu1993
reviewed
Sep 30, 2024
ports/tidy-html5/portfile.cmake
Outdated
| @@ -21,6 +22,7 @@ vcpkg_cmake_configure( | |||
| ) | |||
| vcpkg_cmake_install() | |||
| vcpkg_fixup_pkgconfig() | |||
| vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/tidy-html5) | |||
There was a problem hiding this comment.
Suggested change
| vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/tidy-html5) | |
| vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/unofficial-tidy-html5) |
JonLiu1993
added
the
category:port-bug
|
No usage is provided after installation |
|
I didn't test this PR, but I see different target install commands for static vs. shared. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory."port-version"is reset (removed fromvcpkg.json)../vcpkg x-add-version --alland committing the result.