Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msquic] update to 2.4.5, Change to openssl3 and remove uwp support. #41219

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Sep 27, 2024

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@talregev
Copy link
Contributor Author

talregev commented Sep 27, 2024

the commit 612d8e44d687e4b71c4724319d7aa27a733bcbca
is OpenSSL 1_1_1w+quic and not openssl-3.1.5+quic as HEAD_REF suggested.

I am changing to quictls/openssl3 because I think it more important to update to newer ssl version.
I remove uwp support because it doing compilation error of multiple definition symbols.

@talregev talregev force-pushed the TalR/msquic_openssl3 branch 2 times, most recently from ded0ea8 to acaf09f Compare September 27, 2024 17:51
@talregev talregev changed the title [msquic] Change to openssl3 remove uwp support [msquic] Change to openssl3 and remove uwp support. Sep 27, 2024
@talregev talregev force-pushed the TalR/msquic_openssl3 branch 2 times, most recently from a7d8553 to 7474686 Compare September 27, 2024 17:58
@talregev
Copy link
Contributor Author

failed (exit code 1169) with the following output:
LINK : warning LNK4075: ignoring '/MANIFESTUAC' due to '/MANIFEST:NO' specification
OneCore.lib(KERNEL32.dll) : error LNK2005: VirtualAlloc already defined in platform.lib(datapath_winuser.c.obj)
   Creating library obj\Debug\msquic.lib and object obj\Debug\msquic.exp
bin\Debug\msquic.dll : fatal error LNK1169: one or more multiply defined symbols found
ninja: build stopped: subcommand failed.

failure logs for x64-uwp.zip

@talregev talregev changed the title [msquic] Change to openssl3 and remove uwp support. [msquic] update to 2.4.5, Change to openssl3 and remove uwp support. Sep 28, 2024
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Sep 29, 2024
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Sep 29, 2024
@JavierMatosD JavierMatosD merged commit bbe8dbd into microsoft:master Sep 30, 2024
16 checks passed
@talregev talregev deleted the TalR/msquic_openssl3 branch September 30, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants