DPMMA-2881 fix Grapesjs-Mjml self-closing mj-spacer tag issue #14142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves an issue where self-closing tag
<mj-spacer />
were causing rendering problems in Grapesjs-Mjml.Fix for other self-closing tags was introduced in #13431, this PR just adds
mj-spacer
, to list of void tags.📋 Steps to test this PR:
1: Go to Channels > Emails
2: Create new
3: Select "New template email"
4: Fill in a name for "Subject" and "Internal name"
5: Select the "Brienz" theme - because it uses MJML
6: Go to "Builder"
7: Click on the pencil icon that corresponds to "Edit code"
8: Delete all the code and paste this code:
10: Click save
11: Check if it's rendered correctly: top and bottom text should have a spacer element between