Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-60534 -fix rate my app broken styles #8232

Merged
merged 2 commits into from
Sep 30, 2024
Merged

MM-60534 -fix rate my app broken styles #8232

merged 2 commits into from
Sep 30, 2024

Conversation

pvev
Copy link
Contributor

@pvev pvev commented Sep 26, 2024 •
edited
Loading

Summary

Fix "rate my app" broken styles 🤦

Ticket Link

https://mattermost.atlassian.net/browse/MM-60534

Checklist

  • Added or updated unit tests (required for all new features)
  • [ x] Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on: android and ios emulator

Screenshots

Before:
Screenshot 2024-09-26 at 23 23 39

After:
Android:
Screenshot 2024-09-26 at 22 49 37
Screenshot 2024-09-26 at 22 50 20

ios:
Screenshot 2024-09-26 at 23 04 33

Release Note

NONE

@pvev pvev requested a review from larkox September 26, 2024 21:31
@pvev pvev added the 2: Dev Review Requires review by a core commiter label Sep 26, 2024
@pvev pvev added this to the v2.21.0 milestone Sep 26, 2024
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Sep 26, 2024
@amyblais amyblais removed the 2: Dev Review Requires review by a core commiter label Sep 27, 2024
@pvev pvev added the 3: QA Review Requires review by a QA tester label Sep 27, 2024
@yasserfaraazkhan yasserfaraazkhan added Build Apps for PR Build the mobile app for iOS and Android to test E2E iOS tests for PR Run iOS E2E Detox tests labels Sep 30, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Sep 30, 2024
@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request QA Review Done and removed 3: QA Review Requires review by a QA tester labels Sep 30, 2024
@pvev pvev merged commit 0cbbe72 into main Sep 30, 2024
71 checks passed
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@pvev pvev deleted the MM-60534-rate-my-app-broken-styles branch September 30, 2024 16:17
mattermost-build pushed a commit that referenced this pull request Sep 30, 2024
@pvev @mattermost-build
MM-60534 -fix rate my app broken styles (#8232)
2e5a626 
* MM-60534 -fix rate my app broken styles

* use a simpler and more general approach

(cherry picked from commit 0cbbe72)
@mattermost-build mattermost-build mentioned this pull request Sep 30, 2024
Merged
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 30, 2024
amyblais pushed a commit that referenced this pull request Sep 30, 2024
@mattermost-build @pvev
MM-60534 -fix rate my app broken styles (#8232) (#8239)
aaa9ee9 
* MM-60534 -fix rate my app broken styles

* use a simpler and more general approach

(cherry picked from commit 0cbbe72)

Co-authored-by: Pablo Vélez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@enahum enahum enahum approved these changes

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Build Apps for PR Build the mobile app for iOS and Android to test CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone QA Review Done release-note
Projects
None yet
Milestone
v2.21.0
Development

Successfully merging this pull request may close these issues.
7 participants
@pvev @mattermost-build @larkox @enahum @yasserfaraazkhan @amyblais @mm-cloud-bot