Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove mobile builds out of the template #8000

Merged
merged 8 commits into from
Jun 12, 2024
Merged

fix: Remove mobile builds out of the template #8000

merged 8 commits into from
Jun 12, 2024

Conversation

toninis
Copy link
Contributor

@toninis toninis commented Jun 10, 2024

Summary

  • Remove ios build out of the template

Ticket Link

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on:

Screenshots

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added kind/bug Categorizes issue or PR as related to a bug. release-note labels Jun 10, 2024
@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 10, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 10, 2024
@saturninoabril saturninoabril marked this pull request as ready for review June 11, 2024 01:39
saturninoabril
saturninoabril approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @toninis!

@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 11, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 11, 2024
@toninis toninis added the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 11, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 11, 2024
yasserfaraazkhan
yasserfaraazkhan approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toninis In the CI runs, the tests have issue picking up the long running server. I'll spend time to figure out the issue. But nothing from these changes cause it.

@toninis
Copy link
Contributor Author

toninis commented Jun 11, 2024

@toninis In the CI runs, the tests have issue picking up the long running server. I'll spend time to figure out the issue. But nothing from these changes cause it.

Cool . Strangely for CMT it works https://github.com/mattermost/mattermost-mobile/actions/runs/9467222419

@toninis toninis added the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 12, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 12, 2024
@toninis toninis merged commit c1829bd into main Jun 12, 2024
22 of 23 checks passed
@toninis toninis deleted the fix/cmt-testing branch June 12, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saturninoabril saturninoabril saturninoabril approved these changes

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toninis @saturninoabril @yasserfaraazkhan @mm-cloud-bot