-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix reporting variables in the community report #7997
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
kind/bug
Categorizes issue or PR as related to a bug.
release-note
labels
Jun 7, 2024
yasserfaraazkhan
added
E2E iOS tests for PR
Run iOS E2E Detox tests
and removed
kind/bug
Categorizes issue or PR as related to a bug.
labels
Jun 7, 2024
yasserfaraazkhan
added
E2E iOS tests for PR
Run iOS E2E Detox tests
and removed
kind/bug
Categorizes issue or PR as related to a bug.
labels
Jun 7, 2024
Fixed in favor of e92c1b7 |
yasserfaraazkhan
added
E2E iOS tests for PR
Run iOS E2E Detox tests
and removed
E2E iOS tests for PR
Run iOS E2E Detox tests
labels
Jun 20, 2024
yasserfaraazkhan
added
E2E iOS tests for PR
Run iOS E2E Detox tests
and removed
E2E iOS tests for PR
Run iOS E2E Detox tests
labels
Jun 20, 2024
/update-branch |
yasserfaraazkhan
added
E2E iOS tests for PR
Run iOS E2E Detox tests
and removed
E2E iOS tests for PR
Run iOS E2E Detox tests
labels
Jun 21, 2024
toninis
requested changes
Jun 26, 2024
Comment on lines
64
to
65
BRANCH: ${{ github.head_ref || github.ref_name }} | ||
COMMIT_HASH: ${{ github.sha }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add those . It's best to calculate them during the run to ensure we have the proper values per scenario (scheduled, external trigger , fork ..)
Overall great work 🚀 |
toninis
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before 👇
After ☝️
Ticket Link
Checklist
E2E iOS tests for PR
.Device Information
This PR was tested on:
Screenshots
Release Note