Fix notification impeding the input in the rest of the app #7942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkox
added
2: Dev Review
enahum
approved these changes
May 7, 2024
|
@yasserfaraazkhan I was only able to reproduce this in iOS to begin with. Make sure it works for both Android and iOS. |
yasserfaraazkhan
approved these changes
May 9, 2024
larkox
added
4: Reviews Complete
cyrusjc
pushed a commit
to cyrusjc/mattermost-mobile
that referenced
this pull request
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On react native gesture handler v2.16.0 they changed the default flex for GestureHandlerRootView from 0 to 1.
This caused the gesture handler to fit the whole screen, catching the input even if the overlay was set not to catch taps in the background.
Passing the new flex solves the issue.
Ticket Link
Fix https://mattermost.atlassian.net/browse/MM-32183
Release Note
Issue introduced in #7863 which is not yet in the release branch.