Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-58137 Fix crash by importing the correct Animated component #7937

Merged
merged 1 commit into from
May 7, 2024

Conversation

enahum
Copy link
Contributor

@enahum enahum commented May 6, 2024

Summary

The ImagePreview component for some reason (code from 2Y) ago was using the wrong Animated component, now replaced with the one provided by the reanimated library.

This was causing the library to access a property directly that causes the crash as it should only be accessible in the UI Thread (native side)

This crash is only happening after updating the Reanimated library with all the other deps done for 2.16, so this PR needs to be cherry picked.

Ticket Link

https://mattermost.atlassian.net/browse/MM-58137

Release Note

NONE

@enahum enahum added 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels May 6, 2024
@enahum enahum added this to the v2.16.0 milestone May 6, 2024
@enahum enahum requested a review from marianunez May 6, 2024 21:55
@marianunez
Copy link
Member

This crash is only happening after updating the Reanimated library with all the other deps done for 2.16, so this PR needs to be cherry picked.

Do we need to cherrypick? It seems the dependencies PR didn't make the 2.16 branch #7863

@enahum
Copy link
Contributor Author

enahum commented May 6, 2024

This crash is only happening after updating the Reanimated library with all the other deps done for 2.16, so this PR needs to be cherry picked.

Do we need to cherrypick? It seems the dependencies PR didn't make the 2.16 branch #7863

then no cherry pick

@enahum enahum removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label May 6, 2024
@enahum enahum modified the milestones: v2.16.0, v2.17.0 May 6, 2024
@marianunez
Copy link
Member

This crash is only happening after updating the Reanimated library with all the other deps done for 2.16, so this PR needs to be cherry picked.

Do we need to cherrypick? It seems the dependencies PR didn't make the 2.16 branch #7863

then no cherry pick

@larkox can you confirm that your React Native upgrade is not included in v2.16?

@marianunez marianunez requested a review from larkox May 6, 2024 22:02
@larkox
Copy link
Contributor

larkox commented May 7, 2024

Checking https://github.com/mattermost/mattermost-mobile/compare/v2.15.0..release-2.16 no apparent changes to the reanimated library has been made between these two versions.

@larkox larkox added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels May 7, 2024
@enahum enahum merged commit 1fd32bb into main May 7, 2024
16 checks passed
@enahum enahum deleted the MM-58137 branch May 7, 2024 09:56
cyrusjc pushed a commit to cyrusjc/mattermost-mobile that referenced this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants