Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow to run detox iOS tests #7878

Merged
merged 62 commits into from
Jun 4, 2024
Merged

Add workflow to run detox iOS tests #7878

merged 62 commits into from
Jun 4, 2024

Conversation

yasserfaraazkhan
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan commented Mar 24, 2024 •
edited
Loading

Summary

  • Added ios detox Workflow to run tests
  • Running tests in parallel.
  • Generates combined report and sends to channel.

Ticket Link

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.

Device Information

This PR was tested on:

Screenshots

Release Note

NONE

@yasserfaraazkhan yasserfaraazkhan mentioned this pull request Mar 24, 2024
Closed
@yasserfaraazkhan yasserfaraazkhan marked this pull request as ready for review March 25, 2024 14:07
@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Mar 26, 2024
@yasserfaraazkhan yasserfaraazkhan added E2E iOS tests for PR Run iOS E2E Detox tests and removed E2E iOS tests for PR Run iOS E2E Detox tests labels Mar 26, 2024
@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label May 31, 2024
@yasserfaraazkhan yasserfaraazkhan added E2E iOS tests for PR Run iOS E2E Detox tests and removed E2E iOS tests for PR Run iOS E2E Detox tests labels May 31, 2024
@yasserfaraazkhan yasserfaraazkhan added E2E iOS tests for PR Run iOS E2E Detox tests and removed E2E iOS tests for PR Run iOS E2E Detox tests labels May 31, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label May 31, 2024
@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label May 31, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label May 31, 2024
@yasserfaraazkhan
Copy link
Contributor Author

Hi @mvitale1989
should these changes be okay to merge ?

mvitale1989
mvitale1989 requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@mvitale1989 mvitale1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yasser! I only see one last important point that would needs implementing before merging, everything else that may be improved (like the many status checks) we can do it afterwards 👍

.github/workflows/e2e-detox-ci-template.yml Show resolved Hide resolved
@yasserfaraazkhan yasserfaraazkhan merged commit f46ddb4 into main Jun 4, 2024
4 checks passed
@yasserfaraazkhan yasserfaraazkhan deleted the ios_detox_job branch June 4, 2024 17:13
@amyblais amyblais added this to the v2.18.0 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

@mvitale1989 mvitale1989 mvitale1989 approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core commiter release-note-none
Projects
None yet
Milestone
v2.18.0
Development

Successfully merging this pull request may close these issues.
7 participants
@yasserfaraazkhan @larkox @saturninoabril @mvitale1989 @amyblais @mm-cloud-bot @mattermost-build