Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Scroll to bottom element #7851

Merged
merged 6 commits into from
Mar 26, 2024
Merged

feat: Scroll to bottom element #7851

merged 6 commits into from
Mar 26, 2024

Conversation

tanmaythole
Copy link
Contributor

Scroll to the bottom element added in channels and threads, new messages button was also added.

Summary

It adds new functionality to the pull request channel and thread screen of the mobile app. The problem is there is no easy way to get to the bottom of the channel when you are scrolled up in the channel's history and users are forced to scroll manually, which can be frustrating if you have scrolled up far. This problem is solved by adding a new scroll-down button when the user scrolls up to some height by reading the previous messages. The same button notifies for incoming new messages as the user scrolls.

Ticket Link

Fixes mattermost/mattermost#21269

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.

Device Information

This PR was tested on: Android v12 and Android v10

Screenshots

Release Note

Added a new scroll-down button in the channel and thread screen

@mattermost-build
Copy link
Contributor

Hello @tanmaythole,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@tanmaythole
Copy link
Contributor Author

tanmaythole commented Mar 4, 2024 •
edited
Loading

Related to this PR: #6672

cc: @enahum @matthewbirtch @larkox

@tanmaythole tanmaythole mentioned this pull request Mar 4, 2024
Closed
4 tasks
@matthewbirtch
Copy link
Contributor

Thanks @tanmaythole, from the other PR, this one is still outstanding:

the new messages button should ONLY show if a new messages come in while you're scrolled up in the channel beyond the view of the newly added messages, but it seems to show any time I'm scrolled up beyond the new message line.

@larkox larkox self-requested a review March 6, 2024 09:56
@tanmaythole
Copy link
Contributor Author

Thanks @tanmaythole, from the other PR, this one is still outstanding:

the new messages button should ONLY show if a new messages come in while you're scrolled up in the channel beyond the view of the newly added messages, but it seems to show any time I'm scrolled up beyond the new message line.

Hey @matthewbirtch, I have updated the changes as required. Please check.

@larkox larkox added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester 2: UX Review Requires review by a UX Designer labels Mar 6, 2024
@matthewbirtch matthewbirtch added the Build Apps for PR Build the mobile app for iOS and Android to test label Mar 6, 2024
matthewbirtch
matthewbirtch approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@matthewbirtch matthewbirtch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great to me now @tanmaythole. Thanks for finishing this up!

@matthewbirtch matthewbirtch removed the 2: UX Review Requires review by a UX Designer label Mar 7, 2024
larkox
larkox approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

app/components/post_list/scroll_to_end_view.tsx Outdated Show resolved Hide resolved
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

yasserfaraazkhan
yasserfaraazkhan approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on iOS device and android simulator.

@larkox larkox added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Mar 25, 2024
@larkox
Copy link
Contributor

larkox commented Mar 25, 2024

@enahum Friendly reminder to review this.

enahum
enahum approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

app/components/post_list/scroll_to_end_view.tsx Show resolved Hide resolved
@larkox larkox removed the 2: Dev Review Requires review by a core commiter label Mar 26, 2024
@tanmaythole
Copy link
Contributor Author

Thanks @larkox

@larkox
Copy link
Contributor

larkox commented Mar 26, 2024

@tanmaythole There seems to be still one small ci issue. Can you run npm run i18n-extract?

@larkox larkox merged commit 97b06cc into mattermost:main Mar 26, 2024
4 checks passed
@amyblais amyblais added this to the v2.16.0 milestone Mar 26, 2024
@larkox larkox mentioned this pull request Apr 3, 2024
Merged
@amyblais amyblais added the Docs/Needed Requires documentation label Apr 10, 2024
@cwarnermm cwarnermm added Docs/Not Needed Does not require documentation and removed Docs/Needed Requires documentation labels May 10, 2024
cyrusjc pushed a commit to cyrusjc/mattermost-mobile that referenced this pull request May 18, 2024
@tanmaythole @larkox
@enahum @cyrusjc
feat: Scroll to bottom element (mattermost#7851)
d410286 
* feat: Scroll to bottom element

* fix: Scroll to bottom element message

* refactor: Removed unnecessary code

* refactor: code quality improved

* Update app/components/post_list/scroll_to_end_view.tsx

Co-authored-by: Elias Nahum <[email protected]>

* ci: update i18n

---------

Co-authored-by: Daniel Espino García <[email protected]>
Co-authored-by: Elias Nahum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@matthewbirtch matthewbirtch matthewbirtch approved these changes

@enahum enahum enahum approved these changes

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

Assignees
No one assigned
Labels
Build Apps for PR Build the mobile app for iOS and Android to test Contributor Docs/Not Needed Does not require documentation Lifecycle/1:stale QA Review Done release-note
Projects
None yet
Milestone
v2.16.0
Development

Successfully merging this pull request may close these issues.

RNv2: Scroll to bottom element
9 participants
@tanmaythole @mattermost-build @matthewbirtch @larkox @enahum @yasserfaraazkhan @amyblais @mm-cloud-bot @cwarnermm