Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revset: fix crash on "log --at-op 00000000 -r 'root()'" #4557

Merged
merged 1 commit into from
Oct 1, 2024
Merged

revset: fix crash on "log --at-op 00000000 -r 'root()'" #4557

merged 1 commit into from
Oct 1, 2024

Conversation

yuja
Copy link
Collaborator

@yuja yuja commented Oct 1, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@yuja
revset: fix crash on "log --at-op 00000000 -r 'root()'"
480d8e1 
Spotted while refactoring IdPrefixContext.
martinvonz
martinvonz approved these changes Oct 1, 2024
View reviewed changes
Copy link
Owner

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun case

lib/tests/test_revset.rs Show resolved Hide resolved
@yuja yuja merged commit db226d9 into martinvonz:main Oct 1, 2024
18 checks passed
@yuja yuja deleted the push-xklnskynunql branch October 1, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuja @martinvonz