graphlog: add enum GraphStyle to replace string parameter
#4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
approved these changes
Sep 5, 2024
yuja
force-pushed
the
push-pvwoopoyqzqn
branch
from
93674c0
to
57254e4
Compare
I'm going to add enum GraphStyle, and it's specific to the CLI. node_template_for_key() will be inlined later.
I'll make it error out if the style name is invalid.
It's easier to follow than function call with 3 string parameters.
show_op_diff() has many arguments. Let's make it a bit less.
yuja
force-pushed
the
push-pvwoopoyqzqn
branch
from
57254e4
to
c713c40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md