Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt for WebAssembly; opengl-2 branch] Fix http_file_source #2689

Open
wants to merge 1 commit into
base: opengl-2
Choose a base branch
from

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Aug 5, 2024

The manual changes required for qt webgl1 compilation are here fixed with compile conditionals:

https://github.com/birkskyum/maplibre-native-wasm/tree/main/qt-opengl2#changes-needed-to-the-code

(i'll make sure to clean up this branch - made it in main repo instead of fork by accident)

@birkskyum birkskyum requested a review from ntadej August 5, 2024 22:50
@birkskyum birkskyum changed the title Fix qt wasm webgl1 compilation [Qt for WebAssembly; opengl-2 branch] Fix http_file_source Aug 6, 2024
@ntadej
Copy link
Collaborator

ntadej commented Aug 6, 2024

This is still causing a leak in WASM build. As this is not urgent, let me try to find a proper fix.

Copy link
Collaborator

@ntadej ntadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me also do a review.

@birkskyum
Copy link
Member Author

birkskyum commented Aug 13, 2024

This is still causing a leak in WASM build.

This actually closes a leak in WASM build by allowing the browser to abort tile requests. It's easy to verify, because without this fix the app stalls and crashes shortly after boot due to a lack of cleanup.

@ntadej Can we maybe merge this fix, so that things work out-of-the-box, and then at your convenience you can look into improving on it further if the opengl-2 branch still is relevant at the time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants