CI: Updated to Qbs 2.0.2 #3796
Merged
CI: Updated to Qbs 2.0.2 #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the macOS builds, which were using Qbs from Qt Creator versions 5.0.3 and 7.0.2, which are no longer available to download. Using Qt Creator 5.0.3 was necessary on old versions of macOS since it was the last release using Qt 5. We should be able to use a newer version even when building for macOS 10.12-10.13.
Seems that the behavior of File.exists might have changed between 1.23.1 and 2.0.2, such that it now returns true for an empty string. This change makes the Python detection a little more strict.
I'd rather check for whether the python plugin product is being built to avoid duplicating some logic here, but I'm not sure how.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the macOS builds, which were using Qbs from Qt Creator versions 5.0.3 and 7.0.2, which are no longer available to download.
Using Qt Creator 5.0.3 was necessary on old versions of macOS since it was the last release using Qt 5. We should be able to use a newer version even when building for macOS 10.12-10.13.