Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash when changing file member of custom class #3795

Merged
merged 1 commit into from
Jul 28, 2023

Commits on Jul 28, 2023

  1. Fixed crash when changing file member of custom class

    This crash was caused by an infinite recursion happening when changing
    top-level FilePath values. It only affected Qt 6 builds, because two
    QVariant values that both hold a FilePath value always compared as
    unequal due to FilePath not defining a comparision operator.
    
    In addition to adding the comparison operator, I've also added a
    condition to the updating of the property value. It should only be
    necessary to update the top-level value when a nested value was changed.
    Further more, it now sets mUpdatingDetails as another protection against
    recursive calls.
    
    For completeness I've also added the comparision operator to
    PropertyValue and ObjectRef, though they would not have caused problems
    in this context since they're not used as property display values.
    
    Closes mapeditor#3783
    bjorn committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    195d9c0 View commit details
    Browse the repository at this point in the history