-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Terrain Brush fill full tiles mode toggle-able #3407
base: master
Are you sure you want to change the base?
Conversation
Pressing Ctrl when using the Wang tool should also be able to make it _not_ fill whole tiles when held, and fill whole tiles when not held. Still need to make this toggle-able from a toolbar or something similar.
Add action to the Terrain Tool's toolbar which toggles this mode. Holding Ctrl/Cmd still temporarily switches to the mode that's not currently selected.
@fjnlpy This is great, thanks for working on this! Indeed we'll need a proper icon for this. I guess some schematic, either with a full tile highlighted or we could invert the logic and have an icon that indicates a smaller change will be made. No need to worry about the translations, I'll update those when we reach "string freeze", usually 1-2 weeks before the release. I'm not sure it makes sense to set L as a shortcut for this toggle. Mostly because there is already Ctrl as temporary toggle, we could just leave it empty. Users who use the toggle a lot can set the shortcut themselves. |
Users can add their own shortcut key from the preferences menu if they want.
@bjorn Thanks for responding. I removed the shortcut key and setting one from the preferences menu seems to be working ok. I'm no good at visuals and all the other icons look very nice so I wouldn't want to risk making an icon that isn't very good -- is there someone else who can make a better icon? |
Hi, sorry for my delay in getting back to this, I will add the SVG and resolve conflicts soon :) |
This has been removed on master. I added to it to make the fill full tiles icon appear but now that doesn't seem to be necessary.
This came in through the merge with master. It's not there in master and not added by commits in this branch so it can be removed.
I've added the icon, seems to be working locally for me. I initially had to add to |
Thanks, I'll check it out!
Yes, the creation of a resource file is taken care of by the build system since 1c1e33c, so adding the file to the |
We can just read out the checked state of mToggleFillFullTiles. Also corrected name of icon variable.
Hi, I have tried to address #3082. I hope it is useful.
A few things I wasn't sure about: