Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google backporting #75

Open
wants to merge 69 commits into
base: master
Choose a base branch
from
Open

Google backporting #75

wants to merge 69 commits into from

Conversation

slattarini
Copy link
Contributor

Backport refactorings, enhancements (especially in tests) and c-ares integration implemented in the Google fork of pacparser.

@slattarini
Update to spidermonkey to version 1.8.0-rc1
476a754 
As downloaded from
http://ftp.mozilla.org/pub/mozilla.org/js/js-1.8.0-rc1.tar.gz

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Extend shell-based tests for pactester; not yet passing
b435c52 
This is part of the backporting of Google-specific modifications to
upstream pacparser.

Notice that the tests do not pass yet for the pactester build from the
git repository, but works from the one built from the Google-modified
version. My plan is to use the enhanced test to do the backporting in
a "test-driven" way.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Add C utility library for future uses.
b4afa5a 
Still unused, but will be later properly plumbed in as part of the
backport of Google-specific modifications.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
preparatory refactorings in resolve_host(), step 1
cad6c8c 
To enhance readability, reduce code duplication, and pave the road
for upcoming backporting of Google-specific features.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
myIpAddressEx(): return 127.0.0.1 if unable to determine the local IP.
bc2f253 
That was the documented behavior, but the actual one was to return the
empty string -- which is also inconsistent with the myIpAddress()
behavior, which already returned return 127.0.0.1 if not able to
determine the local IP.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
dnsResolveEx(): on failure, return null, not ""
c85c114 
Same as dnsResolve(); which will allow us to reduce code duplication

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
preparatory refactoring in resolve_host(), step 2
6f5007d 
For less strcpy and more sanity in the callers

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Less duplication in C functions dealing with DNS in JavaScript context
2e84edc 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Allow users to disable Microsoft *Ex() functions
db61851 
But keep them enabled by default.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pactester: better IPv6 addresses support, backport of Google modifica…
887fa1c 
…tions

- support bracketed IPv6 addresses in URLs (rather than choking
  on them)

- everything requiring interactions with actual DNS via c-ares
  is still dummied-out

- snatch the occasion to be more respectful of Google's coding standards
  for shell scripts in our shell-based tests

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Make sure that dnsResolveEx() returns IPv6 addrs before IPv4 addrs
f6ef520 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
make code for resolve_host() somewhat saner
72f7f7c 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pactester.c: pacparser_set_dns_{server,domains} might return error
3e2dd53 
That is, once we actually have c-ares integration, they should do so
when the c-ares library is not available at build time.  So prepare the
existing code to handle such failures.

While at it, slightly improve some existing error messages.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Fix formatting in pacparser.h, remove duplicated comments
239d398 
Arguments to exported functions are already documented in the javadoc-style
comments preceding each declaration. And where they are not, make them so.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Allow user to select which DNS resolver to use
62f6ef8 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Move DNS resolutions internal details in its own file (pacarser_dns.c)
20eb9e5 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Remove few unneeded #include directives
06b394d 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Prepare the stage for upcoming c-ares integration
3b02377 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
cosmetics and stylistic changes
d3f718e 
Also update LGPLv3 notice from the latest version at
<http://www.gnu.org/licenses/gpl-howto.html>

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Add c-ares integration, still quite rough around the edges
7d8e996 
Some stylistic and buglets fixes while at it.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pac_utils.h: couple of cosmetic changes to enhance readability (sligh…
00b8b66 
…tly)
@slattarini
pymod: update license, few stylistic changes
f98d713 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pymod: integrate all new features added to the C library
921eaa0 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pacparser.hL trivial typofix in comments
5e39d26 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Get rid of dns_resolver_t, using strings is simpler & clearer
6e37da6 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pymod: implement the set_dns_resolver_variant() function
a9f256d 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pac_utils.h -> pac_builtins.h
0aa79d7 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Rename: ares_wait_for_all_queries_to_complete() -> ares_wait_for_all_…
9513618 
…queries()

Just to avoid conflicts with the slightly-modified Google's c-ares library.

Fix a couple of typofixes while at it.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Get rid of a couple of C utility functions
51aa9df 
Adding a new one admittedly; but I plan to use it to replace
other more complex ones as well...

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Simplify pacparser_resolve_host_getaddrinfo() implementation
c5142d3 
Reducing potential memory leaks and diffs with pacparser_resolve_host_ares()

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pactester.c: refactor for clarity and less shady memory management
d0c0c89 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
read_file_into_str(): do not return NULL upon reading empty files
c45838f 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Fix docs generation, and update docs.
9e524b2 
Also remove SYMBOL_CACHE_SIZE from doxygen.config, as doxygen says it has
become obsolete. And remove trailing whitespace from doxygen.config.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
make directory structure more flat, switch to setuptools (from distut…
c46245c 
…ils)

For a simplified Makefile and a saner python testing. Start adding python
tests based on PyUnit. More will follow.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Rework error-printing macro to only call user-defined error printing …
c29750d 
…function once

We never prevented that to have collateral effects (e.g., aborting the
program), so we cannot assume it will just return after each call.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
simplify concat_strings()
274bd3a 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Simplify str_replace() slightly, fix a memory leak in the process
2664d47 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
fix another memory leak: we were never calling freeaddrinfo()
a9870c6 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
give a warning on getnameinfo() failures
d6f80fd 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
"foo = realloc(foo, ...)" is a classic anti-pattern which can cause m…
55db2cd 
…emory leaks

On failure, realloc returns NULL. So imagine this scenario: realloc succeeds
the first time, foo is allocated; then it fails the second time, returns NULL,
pointer to originally allocated foo is lost: we have a memory leak.

Thanks [email protected] for highlighting this.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
test_pacparser.py: add short top-level description
a0e759b 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
More tests (for the python module, and for the isInNetEx() function)
ac14db3 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pacparser.c: fix a double-free issue revealed by our new python tests
e428ce1 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pacparser_ares_init(): try harder not to leave things half-initialize…
d85a9e1 
…d in case of a setup error

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
isInNetEx4(); handle a prefix_len of 0 correctly
74fbc5b 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pacparser.h: fix minor typo in comments
ef71ab9 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pactester.c: use __FILE__ rather than hardcoding the filename
ee13301 
Following a suggestion from [email protected]

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pactester: report usage error if -u and -f options are both used
99860ab 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
use gai_strerror(err) rather than strerror(errno) to report getnamein…
f4d0432 
…fo() errors

errno is only set if the return value of getnameinfo() is EAI_SYSTEM

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
concat_strings(): have a saner interface with clearer emory ownership
ef3fda7 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
collect_mallocd_address(): give diagnostics on memory errors
9137816 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
pactester: on malformed URLs, report the original one rather than a p…
5585317 
…artial

(as mangled by our processing involving pointer arithmetic)

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
try even harder not to leave c-ares half-initialized in case of error…
4178d2a 
…s during setup

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
getnameinfo doesn't guarantee that error values will be negative, onl…
697bce3 
…y != 0

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Always return null when resolving an empty hostname
e0a3917 
Some small refactorings while at it.

Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Fix unconsistent indentation
d9c6ef3 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini
Fix one occurrence of inconsistent shell variable expansion
e7d82ef 
Signed-off-by: Stefano Lattarini <[email protected]>
@slattarini slattarini mentioned this pull request Apr 14, 2016
Closed
@manugarg
Copy link
Owner

Changes in this PR are humongous and obviously old. It will be hard to merge it, but there some very useful and interesting tidbits here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slattarini @manugarg