Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web pages #2354

Merged
merged 9 commits into from
Sep 11, 2024
Merged

Update web pages #2354

merged 9 commits into from
Sep 11, 2024

Conversation

mr-tz
Copy link
Collaborator

@mr-tz mr-tz commented Sep 11, 2024 •
edited
Loading

extend text on home page and update to use capa Explorer Web throughout.

preview
image

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@mr-tz mr-tz requested a review from s-ff September 11, 2024 11:05
s-ff
s-ff reviewed Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@s-ff s-ff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
A couple comments for your review

web/explorer/src/components/DescriptionPanel.vue Outdated Show resolved Hide resolved
web/explorer/src/components/DescriptionPanel.vue Outdated Show resolved Hide resolved
@mr-tz mr-tz changed the title Web/update mr Update web pages Sep 11, 2024
mr-tz
mr-tz commented Sep 11, 2024
View reviewed changes
rules Outdated Show resolved Hide resolved
mr-tz
mr-tz commented Sep 11, 2024
View reviewed changes
tests/data Outdated Show resolved Hide resolved
@mr-tz mr-tz requested a review from s-ff September 11, 2024 15:49
s-ff
s-ff approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@s-ff s-ff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.

@mr-tz mr-tz merged commit e07ff1c into master Sep 11, 2024
29 checks passed
@mr-tz mr-tz deleted the web/update-mr branch September 11, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williballenthin williballenthin williballenthin approved these changes

@s-ff s-ff s-ff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-tz @williballenthin @s-ff