Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serverchan3 support for serverchan notification provider #5145

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

easychen
Copy link
Contributor

@easychen easychen commented Oct 1, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #(issue)

UptimeKuma has a notification provider called ServerChan that released a new branch version. This PR adds compatibility for the new branch (by adjusting the API entry through the Sendkey recognition)

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that below changes the URL, could you please link to the docs where this is recommended?
Seems a bit sus otherwise to change to a different second level domain..

server/notification-providers/serverchan.js Outdated Show resolved Hide resolved
@easychen
Copy link
Contributor Author

easychen commented Oct 1, 2024

Official Website: https://sc3.ft07.com
Official Announcement: Chinese
I add a txt under sct.ftqq.com: https://sct.ftqq.com/md/sc3.txt

The reason for changing sendkey to be included in the domain is due to the constant cyclic requests to the API interface by some third-party programs. By using DNS to direct subdomains to 127.0.0.1, we can alleviate the burden on the server.😅

@CommanderStorm
Copy link
Collaborator

Thanks for the adjustments to the notification provider! 🎉

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit 0071775 into louislam:master Oct 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants