Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8630] - Add default root hostname for TXT records #11022

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jaalah-akamai
Copy link
Contributor

@jaalah-akamai jaalah-akamai commented Oct 1, 2024

Description 📝

For A/AAA records we default to the root hostname if left empty or by using @, but we do not do the same for TXT record hostnames. Due to this discrepancy, there has been confusion to whether a TXT record for their root domain was applying correctly, or whether the A/AAAA records they were creating would apply to something like example.com.example.com.

Changes 🔄

  • TXT has been added as a case in the shouldResolve function
  • TXT hostname now defaults to root domain hostname

Target release date 🗓️

N/A

Preview 📷

good.mov

How to test 🧪

Reproduction steps

  • Create domain in cloud manager
  • Add an A record for that domain leaving the hostname field blank or using @
  • Create a TXT record for that domain leaving the hostname field blank or using @
  • Notice the difference in "hostname" column after those records have been saved.
    • The "hostname" column for A/AAAA/MX records reflects the root domain, while the hostname column for TXT records remains blank.

Verification steps

  • Checkout branch or view preview link
  • Observe TXT hostname populated accordingly.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jaalah-akamai jaalah-akamai self-assigned this Oct 1, 2024
@jaalah-akamai jaalah-akamai marked this pull request as ready for review October 1, 2024 02:35
@jaalah-akamai jaalah-akamai requested a review from a team as a code owner October 1, 2024 02:35
@jaalah-akamai jaalah-akamai requested review from hana-linode and hkhalil-akamai and removed request for a team October 1, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants