Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [M3-8598] - Remove Linode Create v1 - Part 2 #11020

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

bnussman-akamai
Copy link
Contributor

@bnussman-akamai bnussman-akamai commented Sep 30, 2024

Description πŸ“

  • Completes the removal of the Linode Create v1 directory (packages/manager/src/features/Linodes/LinodesCreate/) πŸ—‘οΈ
  • Some components from Linode Create v1 are still used so this PR moves those files into appropriate directories πŸ“
  • Doesn't touch any logic, just moves things around βœ‹
  • This PR will be followed up with another PR that renames "Linode Create v2" to just "Linode Create" ✏️

Preview πŸ“·

Before After
Screenshot 2024-09-30 at 4 44 50β€―PM Screenshot 2024-09-30 at 4 44 22β€―PM

How to test πŸ§ͺ

  • Verify I moved files into appropriate directories πŸ“
  • Verify Linode Create v2 still works as expected πŸ‘€
  • Verify moving these files around does not break functionality in other places of the app πŸ‘€

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

Copy link

Coverage Report: βœ…
Base Coverage: 86.98%
Current Coverage: 87.12%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants