fix(logs): Correct spelling of aquired_after_secs tracing field #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging of slow connection acquires was added with #3073 and included tracing fields. One of those fields has an incorrect spelling of
acquirein its name; this PR corrects the spelling.Some users of the crate were interested in collecting metrics or building alerts based on this and related tracing fields. If we simply rename the field, this would be a breaking change. @abonander has mentioned he is open to including both the old spelling and the corrected spelling if there is concern about a breaking change to the log field naming.
Due to previous interest in this or #3004:
cc @jqphu / @Matthias247 / @kukabi